Skip to content

Instantly share code, notes, and snippets.

@koistya
Last active June 8, 2022 09:55
Show Gist options
  • Select an option

  • Save koistya/934a4e452b61017ad611 to your computer and use it in GitHub Desktop.

Select an option

Save koistya/934a4e452b61017ad611 to your computer and use it in GitHub Desktop.
How to add `onscroll` event in ReactJS component
import React from 'react';
let lastScrollY = 0;
let ticking = false;
class App extends React.Component {
componentDidMount() {
window.addEventListener('scroll', this.handleScroll, true);
}
componentWillUnmount() {
window.removeEventListener('scroll', this.handleScroll);
}
nav = React.createRef();
handleScroll = () => {
lastScrollY = window.scrollY;
if (!ticking) {
window.requestAnimationFrame(() => {
this.nav.current.style.top = `${lastScrollY}px`;
ticking = false;
});
ticking = true;
}
};
render() {
return (
<div>
<nav ref={this.nav}>
</nav>
<div>
);
}
}
export default App;
@Mazuh

Mazuh commented Jan 9, 2019

Copy link
Copy Markdown

@ffxsam solution worked fine for me too.

@didiraja

Copy link
Copy Markdown

@jylopez @EEtancelin best solutions, thx!

@victorpunkd

Copy link
Copy Markdown

solved my problem thanks

@paintedbicycle

Copy link
Copy Markdown

If anyone is thinking they are going crazy that it's not working for them, while everyone else is piling on saying it does, try this:

  componentDidMount() {
    window.addEventListener('scroll', this.handleScroll, true);
  }

Note, the third argument of "true".

https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener

@dp21g

dp21g commented Feb 18, 2019

Copy link
Copy Markdown

@paintedbicycle thank you! now it works.

@jerzabek

Copy link
Copy Markdown

If anyone is thinking they are going crazy that it's not working for them, while everyone else is piling on saying it does, try this:

  componentDidMount() {
    window.addEventListener('scroll', this.handleScroll, true);
  }

Note, the third argument of "true".

https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener

Worked for me!

@thedanheller

Copy link
Copy Markdown

window.addEventListener('scroll', this.handleScroll, true);

Thanks!

@sovietski

sovietski commented Jun 6, 2019

Copy link
Copy Markdown

@paintedbicycle Thank you!! This worked for me

@miguelespinoza

miguelespinoza commented Jun 10, 2019

Copy link
Copy Markdown

Thanks this is exactly what I needed to do for a ShadowDOM supported div that used onScroll.
Turns out ShadowDOM does not support scroll listener, it's essentially blocked.

What I did was:

const listNode = ReactDOM.findDOMNode(this.list);
listNode.addEventListener('scroll', this.handleScroll);

and it worked! 🎉

@sushantlp

Copy link
Copy Markdown

If anyone is thinking they are going crazy that it's not working for them, while everyone else is piling on saying it does, try this:

  componentDidMount() {
    window.addEventListener('scroll', this.handleScroll, true);
  }

Note, the third argument of "true".

https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener

Worked for me

@Jesse-efe

Copy link
Copy Markdown

thank you very much @paintedbicycle

@raheemazeezabiodun

Copy link
Copy Markdown

This worked for me:

constructor(props) {
  super(props);
  this.handleScroll = this.handleScroll.bind(this);
}

componentDidMount() {
  window.addEventListener('scroll', this.handleScroll);
};

componentWillUnmount() {
  window.removeEventListener('scroll', this.handleScroll);
};

handleScroll(event) {
  console.log('the scroll things', event)
};

your solution worked for me. Thank you for this

@koistya

koistya commented Aug 4, 2020

Copy link
Copy Markdown
Author

@raheemazeezabiodun Note, that if you use an arrow function syntax for declaring custom handlers, you won't need to bind them to this inside of a constructor function:

constructor(props) {
  supert(props);
  this.handleScroll = this.handleScroll.bind(this);
}

handleScroll(event) { ... };

vs

handleScroll = (event) => { ... };

@Random-Black-Coder

Copy link
Copy Markdown

Is anyone having issues with the event returning as undefined?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment