patyearone

Final Review - Comprehensive PR Review & Testing

Step 0: Determine Review Pass

Before starting, check the git history to determine if this is a follow-up review:

git log --oneline -10 | grep -i "Co-Authored-By: Claude"

lifeart

import Component from "@glimmer/component";
import { tracked } from "@glimmer/tracking";
import Object from "@ember/object";
import { reads } from "@ember/object/computed";
import { validator, buildValidations } from "ember-cp-validations";
import { getOwner } from "@ember/application";

const Validations = buildValidations({
  billing_first_name: {
    descriptionKey: "form.fields.billing_first_name",

rafaltrojanowski

1. Install vscodevim

2. Run from terminal:
defaults write com.microsoft.VSCode ApplePressAndHoldEnabled -bool false # Key repeat

3. jj:
Add to settings.json:

"vim.insertModeKeyBindings": [
        {

Rich-Harris

I've been deceiving you all. I had you believe that Svelte was a UI framework — unlike React and Vue etc, because it shifts work out of the client and into the compiler, but a framework nonetheless.

But that's not exactly accurate. In my defense, I didn't realise it myself until very recently. But with Svelte 3 around the corner, it's time to come clean about what Svelte really is.

Svelte is a language.

Specifically, Svelte is an attempt to answer a question that many people have asked, and a few have answered: what would it look like if we had a language for describing reactive user interfaces?

A few projects that have answered this question:

ef4

How to use positionalParams in Angle Bracket invocation

A component with positionalParams always also has named versions of its parameters. For example, the liquid-if component from liquid-fire has this in its Javascript file:

positionalParams: ['predicate']

So these are equivalent:

runspired

/*
  notifying the store that a record has been remotely deleted and should be fully removed.
*/
function pushDeletion(store, type, id) {
  let record = store.peekRecord(type, id);
  
  if (record !== null) {
    let relationships = {};
    let hasRelationships = false;
    

samselikoff

// tests/helpers/push-mirage-db-into-store.js
import { registerAsyncHelper } from '@ember/test';
import { run } from '@ember/runloop';

let pushMirageDbIntoStore = function(server, store) {
  let tables = Object.keys(server.schema);

  tables.forEach(table => {
    if (server.schema[table].all) {
      let all = server.schema[table].all();

wojteklu

Code is clean if it can be understood easily – by everyone on the team. Clean code can be read and enhanced by a developer other than its original author. With understandability comes readability, changeability, extensibility and maintainability.

---

General rules

1. Follow standard conventions.
2. Keep it simple stupid. Simpler is always better. Reduce complexity as much as possible.
3. Boy scout rule. Leave the campground cleaner than you found it.
4. Always find root cause. Always look for the root cause of a problem.

Design rules

ef4

<select onchange={{action (mut vehicle) value="target.value"}}>
  {{#each vehicles key="@item" as |vehicleChoice|}}
    <option value={{vehicleChoice}} selected={{eq vehicle vehicleChoice}}>{{vehicleChoice}}</option>
  {{/each}}
</select>

rwjblue

• Data Down / Actions Up

  • http://emberjs.jsbin.com/nayaho/edit?html,js - Interdependent select boxes. No observers.
  • http://ember-twiddle.com/2d7246875098d0dbb4a4 - One Way Input

• Plain JSBin's

  • http://rwjblue.jsbin.com/pixeki/edit?html,js,output

• Ember Version Base JSBin's

  • 1.0 - http://emberjs.jsbin.com/juluje/edit?html,js,output

• 1.1 - http://emberjs.jsbin.com/cofufo/edit?html,js,output